From: Dan Carpenter <error27@gmail.com>
Date: Tue, 9 Aug 2011 18:01:33 +0000 (+0300)
Subject: Staging: zcache: signedness bug in tmem_get()
X-Git-Tag: v3.1-rc4~8^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1dcab0875b113a148b6601d87b4e0e3444440339;p=profile%2Fivi%2Fkernel-x86-ivi.git

Staging: zcache: signedness bug in tmem_get()

"ret" needs to be signed for the error handling to work properly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/zcache/tmem.c b/drivers/staging/zcache/tmem.c
index 975e34b..1ca66ea 100644
--- a/drivers/staging/zcache/tmem.c
+++ b/drivers/staging/zcache/tmem.c
@@ -604,7 +604,7 @@ int tmem_get(struct tmem_pool *pool, struct tmem_oid *oidp, uint32_t index,
 	struct tmem_obj *obj;
 	void *pampd;
 	bool ephemeral = is_ephemeral(pool);
-	uint32_t ret = -1;
+	int ret = -1;
 	struct tmem_hashbucket *hb;
 	bool free = (get_and_free == 1) || ((get_and_free == 0) && ephemeral);
 	bool lock_held = false;