From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Fri, 12 Feb 2021 08:46:10 +0000 (+0100)
Subject: crypto: sun8i-ss - fix result memory leak on error path
X-Git-Tag: v5.15~1342^2~154
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1dbc6a1e25be8575d6c4114d1d2b841a796507f7;p=platform%2Fkernel%2Flinux-starfive.git

crypto: sun8i-ss - fix result memory leak on error path

This patch fixes a memory leak on an error path.

Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
index 11cbcbc..0b9aa24 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
@@ -438,8 +438,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
 	kfree(pad);
 
 	memcpy(areq->result, result, algt->alg.hash.halg.digestsize);
-	kfree(result);
 theend:
+	kfree(result);
 	crypto_finalize_hash_request(engine, breq, err);
 	return 0;
 }