From: Davide Italiano Date: Thu, 14 Mar 2019 17:41:29 +0000 (+0000) Subject: [DataFormatters] Delete unused code. Not even exposed in the API. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1dbbf2de330762ff2951d695432bf01e9ed52032;p=platform%2Fupstream%2Fllvm.git [DataFormatters] Delete unused code. Not even exposed in the API. I stumbled upon this while removing LLDB_DISABLE_PYTHON when not needed. llvm-svn: 356176 --- diff --git a/lldb/include/lldb/DataFormatters/DataVisualization.h b/lldb/include/lldb/DataFormatters/DataVisualization.h index 0bd30e3..9b007f2 100644 --- a/lldb/include/lldb/DataFormatters/DataVisualization.h +++ b/lldb/include/lldb/DataFormatters/DataVisualization.h @@ -42,11 +42,6 @@ public: static lldb::TypeSummaryImplSP GetSummaryForType(lldb::TypeNameSpecifierImplSP type_sp); -#ifndef LLDB_DISABLE_PYTHON - static lldb::SyntheticChildrenSP - GetSyntheticChildrenForType(lldb::TypeNameSpecifierImplSP type_sp); -#endif - static lldb::TypeFilterImplSP GetFilterForType(lldb::TypeNameSpecifierImplSP type_sp); diff --git a/lldb/include/lldb/DataFormatters/FormatManager.h b/lldb/include/lldb/DataFormatters/FormatManager.h index 5c776c0..bef7ce5 100644 --- a/lldb/include/lldb/DataFormatters/FormatManager.h +++ b/lldb/include/lldb/DataFormatters/FormatManager.h @@ -129,11 +129,6 @@ public: GetSyntheticForType(lldb::TypeNameSpecifierImplSP type_sp); #endif -#ifndef LLDB_DISABLE_PYTHON - lldb::SyntheticChildrenSP - GetSyntheticChildrenForType(lldb::TypeNameSpecifierImplSP type_sp); -#endif - lldb::TypeValidatorImplSP GetValidatorForType(lldb::TypeNameSpecifierImplSP type_sp); diff --git a/lldb/source/DataFormatters/DataVisualization.cpp b/lldb/source/DataFormatters/DataVisualization.cpp index 300ce2a..390df54 100644 --- a/lldb/source/DataFormatters/DataVisualization.cpp +++ b/lldb/source/DataFormatters/DataVisualization.cpp @@ -58,13 +58,6 @@ DataVisualization::GetSyntheticChildren(ValueObject &valobj, } #endif -#ifndef LLDB_DISABLE_PYTHON -lldb::SyntheticChildrenSP DataVisualization::GetSyntheticChildrenForType( - lldb::TypeNameSpecifierImplSP type_sp) { - return GetFormatManager().GetSyntheticChildrenForType(type_sp); -} -#endif - lldb::TypeFilterImplSP DataVisualization::GetFilterForType(lldb::TypeNameSpecifierImplSP type_sp) { return GetFormatManager().GetFilterForType(type_sp); diff --git a/lldb/source/DataFormatters/FormatManager.cpp b/lldb/source/DataFormatters/FormatManager.cpp index 0dcc024..a0a63b3 100644 --- a/lldb/source/DataFormatters/FormatManager.cpp +++ b/lldb/source/DataFormatters/FormatManager.cpp @@ -381,20 +381,6 @@ FormatManager::GetSyntheticForType(lldb::TypeNameSpecifierImplSP type_sp) { } #endif -#ifndef LLDB_DISABLE_PYTHON -lldb::SyntheticChildrenSP FormatManager::GetSyntheticChildrenForType( - lldb::TypeNameSpecifierImplSP type_sp) { - if (!type_sp) - return lldb::SyntheticChildrenSP(); - lldb::TypeFilterImplSP filter_sp = GetFilterForType(type_sp); - lldb::ScriptedSyntheticChildrenSP synth_sp = GetSyntheticForType(type_sp); - if (filter_sp->GetRevision() > synth_sp->GetRevision()) - return lldb::SyntheticChildrenSP(filter_sp.get()); - else - return lldb::SyntheticChildrenSP(synth_sp.get()); -} -#endif - lldb::TypeValidatorImplSP FormatManager::GetValidatorForType(lldb::TypeNameSpecifierImplSP type_sp) { if (!type_sp)