From: Maxime Ripard Date: Mon, 12 Oct 2020 04:26:40 +0000 (+0900) Subject: drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active X-Git-Tag: accepted/tizen/unified/20201028.123938~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1d6059916173b882b6755dfc6c05bf8027e4b4db;p=platform%2Fkernel%2Flinux-rpi.git drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active The HVS has three FIFOs that can be assigned to a number of PixelValves through a mux. However, changing that FIFO requires that we disable and then enable the pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not just the active ones. Fixes: 87ebcd42fb7b ("drm/vc4: crtc: Assign output to channel automatically") Signed-off-by: Maxime Ripard [hoegeun.kwon: Needed to fix page flip issue of dual hdmi.] Signed-off-by: Hoegeun Kwon Change-Id: Id418d321e3cfc9b992bd1868e8084d9f8694a46e --- diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index 2502405..96aadcb 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -613,7 +613,7 @@ vc4_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) bool is_assigned = false; unsigned int channel; - if (!crtc_state->active || vc4->firmware_kms) + if (!crtc_state->enable || vc4->firmware_kms) continue; /*