From: Michał Winiarski Date: Tue, 23 May 2017 10:23:58 +0000 (+0200) Subject: drm/i915: Remove misleading comment in request_alloc X-Git-Tag: v4.14-rc1~484^2~32^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1d5fd00313c49f7972e3356ac58e0ad7934e1948;p=platform%2Fkernel%2Flinux-rpi.git drm/i915: Remove misleading comment in request_alloc Passing NULL ctx to request_alloc would lead to null-ptr-deref. v2: Let's not replace the comment with a BUG_ON Signed-off-by: Michał Winiarski Reviewed-by: Chris Wilson Link: http://patchwork.freedesktop.org/patch/msgid/20170523102400.9614-1-michal.winiarski@intel.com Signed-off-by: Chris Wilson --- diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c index 1ccf252..0d1e0d8 100644 --- a/drivers/gpu/drm/i915/i915_gem_request.c +++ b/drivers/gpu/drm/i915/i915_gem_request.c @@ -538,9 +538,6 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) * * @engine: engine that we wish to issue the request on. * @ctx: context that the request will be associated with. - * This can be NULL if the request is not directly related to - * any specific user context, in which case this function will - * choose an appropriate context to use. * * Returns a pointer to the allocated request if successful, * or an error code if not.