From: Heesub Shin Date: Wed, 13 Sep 2017 07:21:57 +0000 (+0900) Subject: s5j/serial: refactor up_rxavailable() X-Git-Tag: 1.1_Public_Release~166^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1d47a6689231f07d860440281f6c0025829661cd;p=rtos%2Ftinyara.git s5j/serial: refactor up_rxavailable() When determining the availability of Rx FIFO, combining UFSTAT[8] and UFSTAT[7:0] looks more tidy and clean. Change-Id: I1b35dd2afae710375c0bf616f7eeae615fdb8cd6 Signed-off-by: Heesub Shin --- diff --git a/os/arch/arm/src/s5j/s5j_serial.c b/os/arch/arm/src/s5j/s5j_serial.c index 089ed7a..4f72d15 100644 --- a/os/arch/arm/src/s5j/s5j_serial.c +++ b/os/arch/arm/src/s5j/s5j_serial.c @@ -631,8 +631,8 @@ static bool up_rxavailable(struct uart_dev_s *dev) struct up_dev_s *priv = (struct up_dev_s *)dev->priv; uint32_t ufstat = uart_getreg32(priv, S5J_UART_UFSTAT_OFFSET); - return !!(ufstat & UART_UFSTAT_RX_FIFO_COUNT_MASK) || - (ufstat & UART_UFSTAT_RX_FIFO_FULL_MASK); + return !!(ufstat & (UART_UFSTAT_RX_FIFO_COUNT_MASK | + UART_UFSTAT_RX_FIFO_FULL_MASK)); } /****************************************************************************