From: zhuangfeiran@ict.ac.cn Date: Wed, 28 Mar 2012 23:27:00 +0000 (+0000) Subject: x86 bpf_jit: fix a bug in emitting the 16-bit immediate operand of AND X-Git-Tag: v3.4-rc2~37^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1d24fb3684f347226747c6b11ea426b7b992694e;p=profile%2Fcommon%2Fkernel-common.git x86 bpf_jit: fix a bug in emitting the 16-bit immediate operand of AND When K >= 0xFFFF0000, AND needs the two least significant bytes of K as its operand, but EMIT2() gives it the least significant byte of K and 0x2. EMIT() should be used here to replace EMIT2(). Signed-off-by: Feiran Zhuang Acked-by: Eric Dumazet Signed-off-by: David S. Miller --- diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c index 5671752..5a5b6e4 100644 --- a/arch/x86/net/bpf_jit_comp.c +++ b/arch/x86/net/bpf_jit_comp.c @@ -289,7 +289,7 @@ void bpf_jit_compile(struct sk_filter *fp) EMIT2(0x24, K & 0xFF); /* and imm8,%al */ } else if (K >= 0xFFFF0000) { EMIT2(0x66, 0x25); /* and imm16,%ax */ - EMIT2(K, 2); + EMIT(K, 2); } else { EMIT1_off32(0x25, K); /* and imm32,%eax */ }