From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Wed, 15 Aug 2018 20:10:39 +0000 (-0400)
Subject: media: ov772x: Disable clk on error path
X-Git-Tag: v5.4-rc1~2303^2~59
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1d18c2cd9d38ad639b2e00546b9ee638f2cef4b0;p=platform%2Fkernel%2Flinux-rpi.git

media: ov772x: Disable clk on error path

If ov772x_power_on() is unable to get GPIO rstb,
the clock is left undisabled.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index 0d3ed23..161bc7c 100644
--- a/drivers/media/i2c/ov772x.c
+++ b/drivers/media/i2c/ov772x.c
@@ -864,6 +864,7 @@ static int ov772x_power_on(struct ov772x_priv *priv)
 					     GPIOD_OUT_LOW);
 	if (IS_ERR(priv->rstb_gpio)) {
 		dev_info(&client->dev, "Unable to get GPIO \"reset\"");
+		clk_disable_unprepare(priv->clk);
 		return PTR_ERR(priv->rstb_gpio);
 	}