From: Akira Hatanaka <ahatanaka@apple.com>
Date: Mon, 2 May 2016 22:29:40 +0000 (+0000)
Subject: Remove unneeded test in tryCaptureAsConstant.
X-Git-Tag: llvmorg-3.9.0-rc1~7196
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1cfa27309184d95b3e2f9a4f74d35fb3723856cc;p=platform%2Fupstream%2Fllvm.git

Remove unneeded test in tryCaptureAsConstant.

It isn't necessary to call hasDefaultArg because we can't rematerialize
a captured variable that is a function parameter, regardless of whether
or not it has a default argument. NFC.

llvm-svn: 268318
---

diff --git a/clang/lib/CodeGen/CGBlocks.cpp b/clang/lib/CodeGen/CGBlocks.cpp
index 88786bc..d603d21b 100644
--- a/clang/lib/CodeGen/CGBlocks.cpp
+++ b/clang/lib/CodeGen/CGBlocks.cpp
@@ -262,10 +262,10 @@ static bool isSafeForCXXConstantCapture(QualType type) {
 static llvm::Constant *tryCaptureAsConstant(CodeGenModule &CGM,
                                             CodeGenFunction *CGF,
                                             const VarDecl *var) {
-  // Don't rematerialize default arguments of function parameters.
-  if (auto *PD = dyn_cast<ParmVarDecl>(var))
-    if (PD->hasDefaultArg())
-      return nullptr;
+  // Return if this is a function paramter. We shouldn't try to
+  // rematerialize default arguments of function parameters.
+  if (isa<ParmVarDecl>(var))
+    return nullptr;
 
   QualType type = var->getType();