From: Mohamad Heib Date: Wed, 2 Oct 2019 12:21:27 +0000 (+0300) Subject: IB/core: Fix wrong iterating on ports X-Git-Tag: v5.4-rc3~34^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1cbe866cbcb53338de33cf67262e73f9315a9725;p=platform%2Fkernel%2Flinux-rpi.git IB/core: Fix wrong iterating on ports rdma_for_each_port is already incrementing the iterator's value it receives therefore, after the first iteration the iterator is increased by 2 which eventually causing wrong queries and possible traces. Fix the above by removing the old redundant incrementation that was used before rdma_for_each_port() macro. Cc: Fixes: ea1075edcbab ("RDMA: Add and use rdma_for_each_port") Link: https://lore.kernel.org/r/20191002122127.17571-1-leon@kernel.org Signed-off-by: Mohamad Heib Reviewed-by: Erez Alfasi Signed-off-by: Leon Romanovsky Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/core/security.c b/drivers/infiniband/core/security.c index 1ab423b..6eb6d27 100644 --- a/drivers/infiniband/core/security.c +++ b/drivers/infiniband/core/security.c @@ -426,7 +426,7 @@ int ib_create_qp_security(struct ib_qp *qp, struct ib_device *dev) int ret; rdma_for_each_port (dev, i) { - is_ib = rdma_protocol_ib(dev, i++); + is_ib = rdma_protocol_ib(dev, i); if (is_ib) break; }