From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 3 Aug 2018 19:27:55 +0000 (+0300)
Subject: net: sched: cls_flower: Fix an error code in fl_tmplt_create()
X-Git-Tag: v4.19~410^2~125
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1cbc36a53b60d43daa686280385b1ddbe51d5809;p=platform%2Fkernel%2Flinux-rpi.git

net: sched: cls_flower: Fix an error code in fl_tmplt_create()

We forgot to set the error code on this path, so we return NULL instead
of an error pointer.  In the current code kzalloc() won't fail for small
allocations so this doesn't really affect runtime.

Fixes: b95ec7eb3b4d ("net: sched: cls_flower: implement chain templates")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index e8bd08b..a3b69bb 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -1250,8 +1250,10 @@ static void *fl_tmplt_create(struct net *net, struct tcf_chain *chain,
 		goto errout_tb;
 
 	tmplt = kzalloc(sizeof(*tmplt), GFP_KERNEL);
-	if (!tmplt)
+	if (!tmplt) {
+		err = -ENOMEM;
 		goto errout_tb;
+	}
 	tmplt->chain = chain;
 	err = fl_set_key(net, tb, &tmplt->dummy_key, &tmplt->mask, extack);
 	if (err)