From: Martin Storsjö <martin@martin.st>
Date: Thu, 1 Dec 2011 09:07:35 +0000 (+0200)
Subject: applehttpproto: Use the close function if the open function fails
X-Git-Tag: v0.8b1~388
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ca87d600bc069fe4cf497c410b4f794e88a122d;p=platform%2Fupstream%2Flibav.git

applehttpproto: Use the close function if the open function fails

This should clean up leaked memory.

Signed-off-by: Martin Storsjö <martin@martin.st>
---

diff --git a/libavformat/applehttpproto.c b/libavformat/applehttpproto.c
index 0e64dad..8dbcf2d 100644
--- a/libavformat/applehttpproto.c
+++ b/libavformat/applehttpproto.c
@@ -174,6 +174,17 @@ fail:
     return ret;
 }
 
+static int applehttp_close(URLContext *h)
+{
+    AppleHTTPContext *s = h->priv_data;
+
+    free_segment_list(s);
+    free_variant_list(s);
+    ffurl_close(s->seg_hd);
+    av_free(s);
+    return 0;
+}
+
 static int applehttp_open(URLContext *h, const char *uri, int flags)
 {
     AppleHTTPContext *s;
@@ -229,7 +240,7 @@ static int applehttp_open(URLContext *h, const char *uri, int flags)
     return 0;
 
 fail:
-    av_free(s);
+    applehttp_close(h);
     return ret;
 }
 
@@ -287,17 +298,6 @@ retry:
     goto start;
 }
 
-static int applehttp_close(URLContext *h)
-{
-    AppleHTTPContext *s = h->priv_data;
-
-    free_segment_list(s);
-    free_variant_list(s);
-    ffurl_close(s->seg_hd);
-    av_free(s);
-    return 0;
-}
-
 URLProtocol ff_applehttp_protocol = {
     .name      = "applehttp",
     .url_open  = applehttp_open,