From: Edward Hervey <edward.hervey@collabora.co.uk>
Date: Thu, 14 Jun 2012 13:04:33 +0000 (+0200)
Subject: ffmpegviddec: Properly error out when codec doesn't open
X-Git-Tag: RELEASE-0.11.93~44^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ca115c44bca894a6bbb2334e60a361dbd64a157;p=platform%2Fupstream%2Fgst-libav.git

ffmpegviddec: Properly error out when codec doesn't open

Avoids ending up using an un-set codec
---

diff --git a/ext/ffmpeg/gstffmpegviddec.c b/ext/ffmpeg/gstffmpegviddec.c
index 3554ead..a4afe08 100644
--- a/ext/ffmpeg/gstffmpegviddec.c
+++ b/ext/ffmpeg/gstffmpegviddec.c
@@ -413,7 +413,7 @@ gst_ffmpegviddec_set_format (GstVideoDecoder * decoder,
 {
   GstFFMpegVidDec *ffmpegdec;
   GstFFMpegVidDecClass *oclass;
-  gboolean ret = TRUE;
+  gboolean ret = FALSE;
 
   ffmpegdec = (GstFFMpegVidDec *) decoder;
   oclass = (GstFFMpegVidDecClass *) (G_OBJECT_GET_CLASS (ffmpegdec));
@@ -528,6 +528,8 @@ gst_ffmpegviddec_set_format (GstVideoDecoder * decoder,
     gst_video_codec_state_unref (ffmpegdec->input_state);
   ffmpegdec->input_state = gst_video_codec_state_ref (state);
 
+  ret = TRUE;
+
 done:
   GST_OBJECT_UNLOCK (ffmpegdec);