From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: Tue, 20 Feb 2018 21:05:29 +0000 (+0100)
Subject: rtc: ds1511: let the core handle invalid time
X-Git-Tag: v4.19~1240^2~72
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c90d9f1c80ba28ddb61c3dbdc55ac686c073d75;p=platform%2Fkernel%2Flinux-rpi.git

rtc: ds1511: let the core handle invalid time

Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c
index 5f55214..a7d5ca42 100644
--- a/drivers/rtc/rtc-ds1511.c
+++ b/drivers/rtc/rtc-ds1511.c
@@ -277,10 +277,6 @@ static int ds1511_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm)
 
 	rtc_tm->tm_mon--;
 
-	if (rtc_valid_tm(rtc_tm) < 0) {
-		dev_err(dev, "retrieved date/time is not valid.\n");
-		rtc_time_to_tm(0, rtc_tm);
-	}
 	return 0;
 }