From: Ben Hutchings Date: Sat, 30 Nov 2013 19:12:27 +0000 (+0000) Subject: HID: kye: Fix missing break in kye_report_fixup() X-Git-Tag: v3.12.6~24 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c6d8565e19d345426179f693e46226cad5a5b60;p=kernel%2Fkernel-generic.git HID: kye: Fix missing break in kye_report_fixup() commit 0a5f99cfff2297f6c350b7f54878cbbf1b1253d5 upstream. The change to support Genius Manticore Keyboard also changed behaviour for Genius Gx Imperator Keyboard, as there is no break between the cases. This is presumably a mistake. Reported by Coverity as CID 1134029. Fixes: 4a2c94c9b6c0 ('HID: kye: Add report fixup for Genius Manticore Keyboard') Signed-off-by: Ben Hutchings Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c index 35a4f9c..d645caa 100644 --- a/drivers/hid/hid-kye.c +++ b/drivers/hid/hid-kye.c @@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc, case USB_DEVICE_ID_GENIUS_GX_IMPERATOR: rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83, "Genius Gx Imperator Keyboard"); + break; case USB_DEVICE_ID_GENIUS_MANTICORE: rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104, "Genius Manticore Keyboard");