From: David Müller <dave.mueller@gmx.ch>
Date: Tue, 23 Sep 2008 11:45:51 +0000 (-0400)
Subject: Move _mm_empty() to correct place
X-Git-Tag: 1.0_branch~1246
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c5de7b05831b3d66821707276b71974a232f5c7;p=profile%2Fivi%2Fpixman.git

Move _mm_empty() to correct place

The "fbComposeSetupSSE2()" function is guarding most of its code
depending on the capabilities of the CPU, but unfortunately the call
to "_mm_empty()" is not part of this code path but executed
unconditionally.  This results in a "illegal instruction" crash on
non-MMX / non-SSE capable CPUs caused by the the "emms" instruction
(embedded in "_mm_empty()").

Fix bug 17729.
---

diff --git a/pixman/pixman-sse2.c b/pixman/pixman-sse2.c
index 0f36436..6890f5f 100644
--- a/pixman/pixman-sse2.c
+++ b/pixman/pixman-sse2.c
@@ -2357,11 +2357,11 @@ fbComposeSetupSSE2(void)
         pixman_composeFunctions.combineC[PIXMAN_OP_ADD] = sse2CombineAddC;
 
         pixman_composeFunctions.combineMaskU = sse2CombineMaskU;
+
+	_mm_empty();
     }
 
     initialized = TRUE;
-
-    _mm_empty();
 }