From: John Whitmore Date: Sun, 29 Jul 2018 21:07:47 +0000 (+0100) Subject: staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method - Style X-Git-Tag: v5.15~8191^2~159 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c58e9cc5b56d43b6121792c4b7f81b8dc4463cc;p=platform%2Fkernel%2Flinux-starfive.git staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method - Style The enumerated type DM_CCK_Rx_Path_Method is used as a container for constant definitions, rather then an enumerated type enabling compiler type checking. To correct this, the variable which uses the constants, defined by the enumeration, has had its type changed from a u8 to the enumeration. Additionally the type has been moved above the structure where the type is used, to avoid compiler error. The typedef has been removed from the enumerated type to clear the checkpatch issue with defining new types. The name of the type has been changed to cck_rx_path_method to clear the checkpatch issue with CamelCase naming. And the enumerated constant CCK_Rx_Version_MAX has been removed, since it is never used in code. The changes are all coding style in nature and so should have no impact on runtime code execution. Signed-off-by: John Whitmore Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h index f0e259d..2ba6a42 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.h +++ b/drivers/staging/rtl8192u/r8192U_dm.h @@ -126,10 +126,15 @@ struct dig { long rssi_val; }; +enum cck_rx_path_method { + CCK_Rx_Version_1 = 0, + CCK_Rx_Version_2 = 1, +}; + struct dynamic_rx_path_sel { u8 Enable; u8 DbgMode; - u8 cck_method; + enum cck_rx_path_method cck_method; u8 cck_Rx_path; u8 SS_TH_low; @@ -142,12 +147,6 @@ struct dynamic_rx_path_sel { long cck_pwdb_sta[4]; }; -typedef enum tag_CCK_Rx_Path_Method_Definition { - CCK_Rx_Version_1 = 0, - CCK_Rx_Version_2 = 1, - CCK_Rx_Version_MAX -} DM_CCK_Rx_Path_Method; - typedef enum tag_DM_DbgMode_Definition { DM_DBG_OFF = 0, DM_DBG_ON = 1,