From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 4 Jan 2019 06:47:03 +0000 (+0300)
Subject: nfsd: fix an IS_ERR() vs NULL check
X-Git-Tag: v5.15~6784^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c3da4452d185e4be663e76a1b9842184d8f9c4c;p=platform%2Fkernel%2Flinux-starfive.git

nfsd: fix an IS_ERR() vs NULL check

The get_backchannel_cred() used to return error pointers on error but
now it returns NULL pointers.

Fixes: 97f68c6b02e0 ("SUNRPC: add 'struct cred *' to auth_cred and rpc_cre")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index c74e453..9b38dab 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -913,9 +913,9 @@ static int setup_callback_client(struct nfs4_client *clp, struct nfs4_cb_conn *c
 		return PTR_ERR(client);
 	}
 	cred = get_backchannel_cred(clp, client, ses);
-	if (IS_ERR(cred)) {
+	if (!cred) {
 		rpc_shutdown_client(client);
-		return PTR_ERR(cred);
+		return -ENOMEM;
 	}
 	clp->cl_cb_client = client;
 	clp->cl_cb_cred = cred;