From: Dan Carpenter Date: Wed, 10 Jun 2020 08:59:11 +0000 (+0300) Subject: virtio-mem: silence a static checker warning X-Git-Tag: v5.10.7~2262^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c3d69ab5348b661616992206357a3ebf19b1008;p=platform%2Fkernel%2Flinux-rpi.git virtio-mem: silence a static checker warning Smatch complains that "rc" can be uninitialized if we hit the "break;" statement on the first iteration through the loop. I suspect that this can't happen in real life, but returning a zero literal is cleaner and silence the static checker warning. Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20200610085911.GC5439@mwanda Signed-off-by: Michael S. Tsirkin --- diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 50c689f..5210ff0 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1192,7 +1192,7 @@ static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id, VIRTIO_MEM_MB_STATE_OFFLINE); } - return rc; + return 0; } /*