From: Thibault Saunier <tsaunier@gnome.org>
Date: Sun, 28 Sep 2014 20:37:01 +0000 (+0200)
Subject: validate:scenario: Report an EXECUTION_ERROR on action execution failure
X-Git-Tag: 1.19.3~491^2~1506
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1c2c0e63c2aa6252d06d9c7c9a234a0bf8e663c7;p=platform%2Fupstream%2Fgstreamer.git

validate:scenario: Report an EXECUTION_ERROR on action execution failure

If the action type handles a better error report type, it should just
return TRUE, and report its issue itself.
---

diff --git a/validate/gst/validate/gst-validate-scenario.c b/validate/gst/validate/gst-validate-scenario.c
index 1675fbd..6ed97d9 100644
--- a/validate/gst/validate/gst-validate-scenario.c
+++ b/validate/gst/validate/gst-validate-scenario.c
@@ -895,9 +895,14 @@ get_position (GstValidateScenario * scenario)
 
     GST_DEBUG_OBJECT (scenario, "Executing %" GST_PTR_FORMAT
         " at %" GST_TIME_FORMAT, act->structure, GST_TIME_ARGS (position));
-    if (!type->execute (scenario, act))
-      GST_WARNING_OBJECT (scenario, "Could not execute %" GST_PTR_FORMAT,
-          act->structure);
+    if (!type->execute (scenario, act)) {
+      gchar *str = gst_structure_to_string (act->structure);
+
+      GST_VALIDATE_REPORT (scenario,
+          SCENARIO_ACTION_EXECUTION_ERROR, "Could not execute %s", str);
+
+      g_free (str);
+    }
 
     if (act->repeat > 0) {
       act->repeat--;