From: Justin Van Patten Date: Thu, 7 Jul 2016 21:18:47 +0000 (-0700) Subject: Avoid box allocation in Encoding.EncodingName (dotnet/coreclr#6142) X-Git-Tag: submit/tizen/20210909.063632~11030^2~9928 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1becf213679302ef5ad474b3d48d479b0792bfc7;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Avoid box allocation in Encoding.EncodingName (dotnet/coreclr#6142) `Encoding.EncodingName` concatenates a `string` with an `int` via `string.Concat(object, object)`, which results in the `int` being boxed. This change avoids the box by calling `int.ToString()`, allowing `string.Concat(string, string)` to be used. Commit migrated from https://github.com/dotnet/coreclr/commit/a73353e66181706bc98a65b92a921d476bfd322d --- diff --git a/src/coreclr/src/mscorlib/src/System/Text/Encoding.cs b/src/coreclr/src/mscorlib/src/System/Text/Encoding.cs index 5a0ce140b30..3d38d146629 100644 --- a/src/coreclr/src/mscorlib/src/System/Text/Encoding.cs +++ b/src/coreclr/src/mscorlib/src/System/Text/Encoding.cs @@ -722,7 +722,7 @@ namespace System.Text { get { - return (Environment.GetResourceString("Globalization.cp_" + m_codePage)); + return Environment.GetResourceString("Globalization.cp_" + m_codePage.ToString()); } }