From: Peter Collingbourne Date: Mon, 20 Mar 2023 23:38:54 +0000 (-0700) Subject: Disable __sancov_lowest_stack on Windows. X-Git-Tag: upstream/17.0.6~14201 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1bd8e87e1b44d23c78f43caa6d419210954821b7;p=platform%2Fupstream%2Fllvm.git Disable __sancov_lowest_stack on Windows. Should fix Windows buildbot: https://lab.llvm.org/buildbot/#/builders/127/builds/45401 --- diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp index f2dd6b2..ce43269 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp @@ -284,7 +284,10 @@ SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_cov_pcs_init, const uptr* beg, // E.g., -fsanitize=fuzzer-no-link // FIXME: Update Apple deployment target so that thread_local is always // supported, and remove the #if. -#if !SANITIZER_APPLE +// FIXME: Figure out how this should work on Windows, exported thread_local +// symbols are not supported: +// "data with thread storage duration may not have dll interface" +#if !SANITIZER_APPLE && !SANITIZER_WINDOWS SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE thread_local uptr __sancov_lowest_stack; #endif