From: Darrick J. Wong Date: Thu, 24 Aug 2017 17:22:06 +0000 (-0400) Subject: ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets X-Git-Tag: v4.14-rc1~134^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1bd8d6cd3e413d64e543ec3e69ff43e75a1cf1ea;p=platform%2Fkernel%2Flinux-exynos.git ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets In the ext4 implementations of SEEK_HOLE and SEEK_DATA, make sure we return -ENXIO for negative offsets instead of banging around inside the extent code and returning -EFSCORRUPTED. Reported-by: Mateusz S Signed-off-by: Darrick J. Wong Signed-off-by: Theodore Ts'o Cc: stable@vger.kernel.org # 4.6 --- diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 0d7cf0c..86ea1d9 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -595,7 +595,7 @@ static loff_t ext4_seek_data(struct file *file, loff_t offset, loff_t maxsize) inode_lock(inode); isize = i_size_read(inode); - if (offset >= isize) { + if (offset < 0 || offset >= isize) { inode_unlock(inode); return -ENXIO; } @@ -658,7 +658,7 @@ static loff_t ext4_seek_hole(struct file *file, loff_t offset, loff_t maxsize) inode_lock(inode); isize = i_size_read(inode); - if (offset >= isize) { + if (offset < 0 || offset >= isize) { inode_unlock(inode); return -ENXIO; }