From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Tue, 25 May 2021 06:35:27 +0000 (+0200)
Subject: pwm: imx1: Don't disable clocks at device remove time
X-Git-Tag: v5.15~710^2~36
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1bc6ea31cb41d50302a3c9b401964cf0a88d41f9;p=platform%2Fkernel%2Flinux-starfive.git

pwm: imx1: Don't disable clocks at device remove time

The .remove() callback disables clocks that were not enabled in
.probe(). So just probing and then unbinding the driver results in a clk
enable imbalance.

So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove()).

Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---

diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c
index c957b36..e73858a 100644
--- a/drivers/pwm/pwm-imx1.c
+++ b/drivers/pwm/pwm-imx1.c
@@ -168,8 +168,6 @@ static int pwm_imx1_remove(struct platform_device *pdev)
 {
 	struct pwm_imx1_chip *imx = platform_get_drvdata(pdev);
 
-	pwm_imx1_clk_disable_unprepare(&imx->chip);
-
 	return pwmchip_remove(&imx->chip);
 }