From: Dan Liew Date: Wed, 28 Apr 2021 21:06:28 +0000 (-0700) Subject: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix. X-Git-Tag: llvmorg-14-init~8129 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1bbbcff99de8e53b89146386bb2587ed4fc8e9cf;p=platform%2Fupstream%2Fllvm.git [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix. This is post commit follow up based on discussions in https://reviews.llvm.org/D101122. Differential Revision: https://reviews.llvm.org/D101490 (cherry picked from commit f4c7e82d1b21e637c4e0c53125b126c407d8bdbf) --- diff --git a/clang/include/clang/Basic/CodeGenOptions.def b/clang/include/clang/Basic/CodeGenOptions.def index 68ebcc6..d30dca5 100644 --- a/clang/include/clang/Basic/CodeGenOptions.def +++ b/clang/include/clang/Basic/CodeGenOptions.def @@ -219,7 +219,7 @@ CODEGENOPT(SanitizeAddressGlobalsDeadStripping, 1, 0) ///< Enable linker dead st CODEGENOPT(SanitizeAddressUseOdrIndicator, 1, 0) ///< Enable ODR indicator globals CODEGENOPT(SanitizeMemoryTrackOrigins, 2, 0) ///< Enable tracking origins in ///< MemorySanitizer -ENUM_CODEGENOPT(SanitizeAddressDtorKind, llvm::AsanDtorKind, 2, +ENUM_CODEGENOPT(SanitizeAddressDtor, llvm::AsanDtorKind, 2, llvm::AsanDtorKind::Global) ///< Set how ASan global ///< destructors are emitted. CODEGENOPT(SanitizeMemoryUseAfterDtor, 1, 0) ///< Enable use-after-delete detection diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 1b4dfe4..eaebed5 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -1548,7 +1548,7 @@ def sanitize_address_destructor_kind_EQ Values<"none,global">, NormalizedValuesScope<"llvm::AsanDtorKind">, NormalizedValues<["None", "Global"]>, - MarshallingInfoEnum, "Global">; + MarshallingInfoEnum, "Global">; // Note: This flag was introduced when it was necessary to distinguish between // ABI for correct codegen. This is no longer needed, but the flag is // not removed since targeting either ABI will behave the same. diff --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp index 844fe4c..6df2d29 100644 --- a/clang/lib/CodeGen/BackendUtil.cpp +++ b/clang/lib/CodeGen/BackendUtil.cpp @@ -287,7 +287,7 @@ static void addAddressSanitizerPasses(const PassManagerBuilder &Builder, bool UseAfterScope = CGOpts.SanitizeAddressUseAfterScope; bool UseOdrIndicator = CGOpts.SanitizeAddressUseOdrIndicator; bool UseGlobalsGC = asanUseGlobalsGC(T, CGOpts); - llvm::AsanDtorKind DestructorKind = CGOpts.getSanitizeAddressDtorKind(); + llvm::AsanDtorKind DestructorKind = CGOpts.getSanitizeAddressDtor(); PM.add(createAddressSanitizerFunctionPass(/*CompileKernel*/ false, Recover, UseAfterScope)); PM.add(createModuleAddressSanitizerLegacyPassPass( @@ -1150,7 +1150,7 @@ static void addSanitizers(const Triple &TargetTriple, bool ModuleUseAfterScope = asanUseGlobalsGC(TargetTriple, CodeGenOpts); bool UseOdrIndicator = CodeGenOpts.SanitizeAddressUseOdrIndicator; llvm::AsanDtorKind DestructorKind = - CodeGenOpts.getSanitizeAddressDtorKind(); + CodeGenOpts.getSanitizeAddressDtor(); MPM.addPass(RequireAnalysisPass()); MPM.addPass(ModuleAddressSanitizerPass( CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator,