From: lepton Date: Wed, 19 Apr 2006 05:21:10 +0000 (-0700) Subject: [PATCH] asm-i386/atomic.h: local_irq_save should be used instead of local_irq_disable X-Git-Tag: v2.6.17-rc3~115 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1bb858f27eadc54e24dfa351fcae724cff426de2;p=platform%2Fkernel%2Flinux-stable.git [PATCH] asm-i386/atomic.h: local_irq_save should be used instead of local_irq_disable atomic_add_return() if CONFIG_M386 can accidentally enable local interrupts. Signed-off-by: Lepton Wu Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/include/asm-i386/atomic.h b/include/asm-i386/atomic.h index 22d80ec..4ddce52 100644 --- a/include/asm-i386/atomic.h +++ b/include/asm-i386/atomic.h @@ -183,6 +183,7 @@ static __inline__ int atomic_add_return(int i, atomic_t *v) { int __i; #ifdef CONFIG_M386 + unsigned long flags; if(unlikely(boot_cpu_data.x86==3)) goto no_xadd; #endif @@ -196,10 +197,10 @@ static __inline__ int atomic_add_return(int i, atomic_t *v) #ifdef CONFIG_M386 no_xadd: /* Legacy 386 processor */ - local_irq_disable(); + local_irq_save(flags); __i = atomic_read(v); atomic_set(v, i + __i); - local_irq_enable(); + local_irq_restore(flags); return i + __i; #endif }