From: Kadir Cetinkaya <kadircet@google.com>
Date: Fri, 24 Jan 2020 10:35:24 +0000 (+0100)
Subject: [clangd][Hover] Change arrow in return type back to →
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1b996faa1575bda6b99e778aaabe14834c10d3ff;p=platform%2Fupstream%2Fllvm.git

[clangd][Hover] Change arrow in return type back to →

Summary:
Currently 🡺 is used in hover response to represent return types, but it
is not widely available. Changing this back to original to support more clients.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D73336
---

diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp
index 1b7a487..26b6cf4 100644
--- a/clang-tools-extra/clangd/Hover.cpp
+++ b/clang-tools-extra/clangd/Hover.cpp
@@ -546,11 +546,11 @@ markup::Document HoverInfo::present() const {
   // editor, as they might be long.
   if (ReturnType) {
     // For functions we display signature in a list form, e.g.:
-    // 🡺 `x`
+    // → `x`
     // Parameters:
     // - `bool param1`
     // - `int param2 = 5`
-    Output.addParagraph().appendText("🡺").appendCode(*ReturnType);
+    Output.addParagraph().appendText("→").appendCode(*ReturnType);
     if (Parameters && !Parameters->empty()) {
       Output.addParagraph().appendText("Parameters:");
       markup::BulletList &L = Output.addBulletList();
diff --git a/clang-tools-extra/clangd/test/hover.test b/clang-tools-extra/clangd/test/hover.test
index 79f7a01..ec8d048 100644
--- a/clang-tools-extra/clangd/test/hover.test
+++ b/clang-tools-extra/clangd/test/hover.test
@@ -9,7 +9,7 @@
 # CHECK-NEXT:  "result": {
 # CHECK-NEXT:    "contents": {
 # CHECK-NEXT:      "kind": "plaintext",
-# CHECK-NEXT:      "value": "function foo\n\n🡺 void\n\nvoid foo()"
+# CHECK-NEXT:      "value": "function foo\n\n→ void\n\nvoid foo()"
 # CHECK-NEXT:    },
 # CHECK-NEXT:    "range": {
 # CHECK-NEXT:      "end": {
diff --git a/clang-tools-extra/clangd/unittests/HoverTests.cpp b/clang-tools-extra/clangd/unittests/HoverTests.cpp
index 87dd056..bb14ede 100644
--- a/clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ b/clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -1744,7 +1744,7 @@ template <typename T, typename C = bool> class Foo {})",
           },
           R"(function foo
 
-🡺 ret_type
+→ ret_type
 Parameters:
 - 
 - type