From: Igor Kotrasinski Date: Thu, 20 Aug 2015 08:00:01 +0000 (+0200) Subject: usb: gadget: composite: fill bcdUSB for any gadget max speed X-Git-Tag: submit/tizen/20160107.053914~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1b80e921f423a6cc34e255cb1d35de7053eadc0c;p=platform%2Fkernel%2Flinux-exynos.git usb: gadget: composite: fill bcdUSB for any gadget max speed When handling device GET_DESCRIPTOR, composite gadget driver fills the bcdUSB field only if the gadget supports USB 3.0. Otherwise the field is left unfilled. For consistency, set bcdUSB to 0x0200 for gadgets that don't support superspeed. It's correct to use 0x0200 for any setting that doesn't use superspeed, since USB 2.0 devices can restrict themselves to full speed only. It is NOT correct to use 0x0210, since BOS descriptors are handled only if gadget_is_superspeed() is satisfied, otherwise it results in a stall. Signed-off-by: Igor Kotrasinski Signed-off-by: Felipe Balbi [Backported from mainline commit 5527e73305e8a9958b00331902a27514e62d539b] Change-Id: Icd543a5b83c6b915be4ba54343ce979145f7e15d Signed-off-by: Krzysztof Opasiak --- diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 13adfd1a3f54..1ca1c00c19d4 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -1492,6 +1492,8 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) } else { cdev->desc.bcdUSB = cpu_to_le16(0x0210); } + } else { + cdev->desc.bcdUSB = cpu_to_le16(0x0200); } value = min(w_length, (u16) sizeof cdev->desc);