From: Jason Yan Date: Wed, 29 Apr 2020 14:09:24 +0000 (+0800) Subject: rtlwifi: remove comparison of 0/1 to bool variable X-Git-Tag: v5.10.7~2469^2~261^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1b56bed20212390432541c7a54e5a70561809293;p=platform%2Fkernel%2Flinux-rpi.git rtlwifi: remove comparison of 0/1 to bool variable The variable 'rtlpriv->rfkill.rfkill_state' is bool and can directly assigned to bool values. Fix the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/core.c:1725:14-42: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200429140924.7750-1-yanaijie@huawei.com --- diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c index f73e690bbe8e..4dd82c6052f0 100644 --- a/drivers/net/wireless/realtek/rtlwifi/core.c +++ b/drivers/net/wireless/realtek/rtlwifi/core.c @@ -1722,7 +1722,7 @@ static void rtl_op_rfkill_poll(struct ieee80211_hw *hw) "wireless radio switch turned %s\n", radio_state ? "on" : "off"); - blocked = (rtlpriv->rfkill.rfkill_state == 1) ? 0 : 1; + blocked = !rtlpriv->rfkill.rfkill_state; wiphy_rfkill_set_hw_state(hw->wiphy, blocked); } }