From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 7 Apr 2020 09:27:53 +0000 (+0300)
Subject: mailbox: imx: Fix return in imx_mu_scu_xlate()
X-Git-Tag: v5.15~3604^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1b3a347b7d56aa637157da1b7df225071af1421f;p=platform%2Fkernel%2Flinux-starfive.git

mailbox: imx: Fix return in imx_mu_scu_xlate()

This called from mbox_request_channel().  The caller is  expecting error
pointers and not NULL so this "return NULL;" will lead to an Oops.

Fixes: 0a67003b1985 ("mailbox: imx: add SCU MU support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index 97bf0acf51d8..cacc60662f24 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -378,7 +378,7 @@ static struct mbox_chan *imx_mu_scu_xlate(struct mbox_controller *mbox,
 		break;
 	default:
 		dev_err(mbox->dev, "Invalid chan type: %d\n", type);
-		return NULL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (chan >= mbox->num_chans) {