From: Shaohua Li Date: Fri, 6 Apr 2012 17:37:47 +0000 (-0600) Subject: block: make auto block plug flush threshold per-disk based X-Git-Tag: v3.4-rc3~13^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1b2e19f17ed327af6add02978efdf354e4f8e4df;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git block: make auto block plug flush threshold per-disk based We do auto block plug flush to reduce latency, the threshold is 16 requests. This works well if the task is accessing one or two drives. The problem is if the task is accessing a raid 0 device and the raid disk number is big, say 8 or 16, 16/8 = 2 or 16/16=1, we will have heavy lock contention. This patch makes the threshold per-disk based. The latency should be still ok accessing one or two drives. The setup with application accessing a lot of drives in the meantime uaually is big machine, avoiding lock contention is more important, because any contention will actually increase latency. Signed-off-by: Shaohua Li Signed-off-by: Jens Axboe --- diff --git a/block/blk-core.c b/block/blk-core.c index 414e822..1f61b74 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1277,7 +1277,8 @@ static bool attempt_plug_merge(struct request_queue *q, struct bio *bio, list_for_each_entry_reverse(rq, &plug->list, queuelist) { int el_ret; - (*request_count)++; + if (rq->q == q) + (*request_count)++; if (rq->q != q || !blk_rq_merge_ok(rq, bio)) continue;