From: Oliver Neukum <oneukum@suse.de>
Date: Mon, 2 Apr 2007 12:47:59 +0000 (+0200)
Subject: kref: fix CPU ordering with respect to krefs
X-Git-Tag: v3.12-rc1~30667^2~34
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1b0b3b9980e482ab7c603430462538334f69f14a;p=kernel%2Fkernel-generic.git

kref: fix CPU ordering with respect to krefs

some atomic operations are only atomic, not ordered. Thus a CPU is allowed
to reorder memory references to an object to before the reference is
obtained. This fixes it.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/lib/kref.c b/lib/kref.c
index 0d07cc3..a6dc3ec 100644
--- a/lib/kref.c
+++ b/lib/kref.c
@@ -21,6 +21,7 @@
 void kref_init(struct kref *kref)
 {
 	atomic_set(&kref->refcount,1);
+	smp_mb();
 }
 
 /**
@@ -31,6 +32,7 @@ void kref_get(struct kref *kref)
 {
 	WARN_ON(!atomic_read(&kref->refcount));
 	atomic_inc(&kref->refcount);
+	smp_mb__after_atomic_inc();
 }
 
 /**