From: Davide Caratti Date: Tue, 11 Feb 2020 18:33:39 +0000 (+0100) Subject: net/sched: matchall: add missing validation of TCA_MATCHALL_FLAGS X-Git-Tag: v5.10.7~3219^2~7^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1afa3cc90f8fb745c777884d79eaa1001d6927a6;p=platform%2Fkernel%2Flinux-rpi.git net/sched: matchall: add missing validation of TCA_MATCHALL_FLAGS unlike other classifiers that can be offloaded (i.e. users can set flags like 'skip_hw' and 'skip_sw'), 'cls_matchall' doesn't validate the size of netlink attribute 'TCA_MATCHALL_FLAGS' provided by user: add a proper entry to mall_policy. Fixes: b87f7936a932 ("net/sched: Add match-all classifier hw offloading.") Signed-off-by: Davide Caratti Acked-by: Jiri Pirko Signed-off-by: David S. Miller --- diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c index 039cc86..610a0b7 100644 --- a/net/sched/cls_matchall.c +++ b/net/sched/cls_matchall.c @@ -157,6 +157,7 @@ static void *mall_get(struct tcf_proto *tp, u32 handle) static const struct nla_policy mall_policy[TCA_MATCHALL_MAX + 1] = { [TCA_MATCHALL_UNSPEC] = { .type = NLA_UNSPEC }, [TCA_MATCHALL_CLASSID] = { .type = NLA_U32 }, + [TCA_MATCHALL_FLAGS] = { .type = NLA_U32 }, }; static int mall_set_parms(struct net *net, struct tcf_proto *tp,