From: Arvind Yadav Date: Wed, 21 Dec 2016 05:30:12 +0000 (+0530) Subject: drm/sti: sti_vtg: Handle return NULL error from devm_ioremap_nocache X-Git-Tag: v4.14-rc1~1422^2~45^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ae0d5af347df224a6e76334683f13a96d915a44;p=platform%2Fkernel%2Flinux-rpi3.git drm/sti: sti_vtg: Handle return NULL error from devm_ioremap_nocache Here, If devm_ioremap_nocache will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav Acked-by: Vincent Abriou --- diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c index a8882bd..c3d9c8a 100644 --- a/drivers/gpu/drm/sti/sti_vtg.c +++ b/drivers/gpu/drm/sti/sti_vtg.c @@ -429,6 +429,10 @@ static int vtg_probe(struct platform_device *pdev) return -ENOMEM; } vtg->regs = devm_ioremap_nocache(dev, res->start, resource_size(res)); + if (!vtg->regs) { + DRM_ERROR("failed to remap I/O memory\n"); + return -ENOMEM; + } np = of_parse_phandle(pdev->dev.of_node, "st,slave", 0); if (np) {