From: Tim Pambor <tp@osasysteme.de>
Date: Thu, 15 Jun 2023 15:06:28 +0000 (+0000)
Subject: virgl: Fix stack overflow in virgl_bind_sampler_states
X-Git-Tag: upstream/23.3.3~6916
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ad79cb84fc3cd5d2a3a4db532ec976ec4bcf5d1;p=platform%2Fupstream%2Fmesa.git

virgl: Fix stack overflow in virgl_bind_sampler_states

Triggered on hosts with more than 32 samplers.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9207
Fixes: 63c4c559 ("virgl: obtain supported number of shader sampler views from host")
Signed-off-by: Tim Pambor <tp@osasysteme.de>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23678>
---

diff --git a/src/gallium/drivers/virgl/virgl_context.c b/src/gallium/drivers/virgl/virgl_context.c
index 983f52f..751561c 100644
--- a/src/gallium/drivers/virgl/virgl_context.c
+++ b/src/gallium/drivers/virgl/virgl_context.c
@@ -1181,7 +1181,7 @@ static void virgl_bind_sampler_states(struct pipe_context *ctx,
                                      void **samplers)
 {
    struct virgl_context *vctx = virgl_context(ctx);
-   uint32_t handles[32];
+   uint32_t handles[PIPE_MAX_SHADER_SAMPLER_VIEWS];
    int i;
    for (i = 0; i < num_samplers; i++) {
       handles[i] = (unsigned long)(samplers[i]);