From: Christopher Michael Date: Thu, 2 May 2019 12:11:20 +0000 (+0200) Subject: eo_test_manager_xattr: Fix resource leak X-Git-Tag: accepted/tizen/unified/20190509.041000~44 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ad1a458931232ffe08e25fec83c81066e94c420;p=platform%2Fupstream%2Fefl.git eo_test_manager_xattr: Fix resource leak Summary: Coverity reports that we leak the eina_binbuf returned from eina_value_to_binbuf function, so add a call to eina_binbuf_free. Fixes CID1400953 @fix Depends on D8762 Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi Reviewed By: segfaultxavi Subscribers: segfaultxavi, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8769 --- diff --git a/src/tests/eio/eio_test_manager_xattr.c b/src/tests/eio/eio_test_manager_xattr.c index e0aae0d..b62f426 100644 --- a/src/tests/eio/eio_test_manager_xattr.c +++ b/src/tests/eio/eio_test_manager_xattr.c @@ -80,11 +80,13 @@ _future_done_cb(void *data EINA_UNUSED, fail_if(!buf); fail_if(strcmp((const char*) eina_binbuf_string_get(buf), attr_data[i]) != 0); + eina_binbuf_free(buf); } fail_if((int) i != total_attributes); ecore_main_loop_quit(); + return array; }