From: Antoine Tenart Date: Wed, 26 Feb 2020 14:40:34 +0000 (+0100) Subject: net: phy: mscc: add missing shift for media operation mode selection X-Git-Tag: v5.15~4200^2~310 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ac7b090ec4618a339afa6d25ab4033c57b30a28;p=platform%2Fkernel%2Flinux-starfive.git net: phy: mscc: add missing shift for media operation mode selection This patch adds a missing shift for the media operation mode selection. This does not fix the driver as the current operation mode (copper) has a value of 0, but this wouldn't work for other modes. Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index 937ac7d..8804254 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -2813,8 +2813,8 @@ static int vsc8584_config_init(struct phy_device *phydev) val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1); val &= ~(MEDIA_OP_MODE_MASK | VSC8584_MAC_IF_SELECTION_MASK); - val |= MEDIA_OP_MODE_COPPER | (VSC8584_MAC_IF_SELECTION_SGMII << - VSC8584_MAC_IF_SELECTION_POS); + val |= (MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS) | + (VSC8584_MAC_IF_SELECTION_SGMII << VSC8584_MAC_IF_SELECTION_POS); ret = phy_write(phydev, MSCC_PHY_EXT_PHY_CNTL_1, val); ret = genphy_soft_reset(phydev); @@ -3276,7 +3276,7 @@ static int vsc8514_config_init(struct phy_device *phydev) return ret; ret = phy_modify(phydev, MSCC_PHY_EXT_PHY_CNTL_1, MEDIA_OP_MODE_MASK, - MEDIA_OP_MODE_COPPER); + MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS); if (ret) return ret;