From: Sangchul Lee Date: Thu, 8 Jun 2017 02:18:05 +0000 (+0900) Subject: fixup! Add new internal APIs to add/remove device id to stream_info and to get device... X-Git-Tag: submit/tizen/20170608.040824^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1a55590d380b3ebba2684b47ef7a6a63b4a8c89c;p=platform%2Fcore%2Fapi%2Fsound-manager.git fixup! Add new internal APIs to add/remove device id to stream_info and to get device state by id Remove wrong parameter checking codes. Fix sound_manager_test to test new API properly. [Version] 0.4.4 [Issue Type] Bug fix Change-Id: I1808e6406fb622df767febc6604cc07c91b68be1 Signed-off-by: Sangchul Lee --- diff --git a/packaging/capi-media-sound-manager.spec b/packaging/capi-media-sound-manager.spec index 691ffe4..2f6061a 100644 --- a/packaging/capi-media-sound-manager.spec +++ b/packaging/capi-media-sound-manager.spec @@ -1,6 +1,6 @@ Name: capi-media-sound-manager Summary: Sound Manager library -Version: 0.4.3 +Version: 0.4.4 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/src/sound_manager_private.c b/src/sound_manager_private.c index e64a783..b12b0ec 100644 --- a/src/sound_manager_private.c +++ b/src/sound_manager_private.c @@ -2001,7 +2001,6 @@ int _add_device_id_for_stream_routing(sound_stream_info_s *stream_info, int devi MMSoundDevice_t device = NULL; SM_INSTANCE_CHECK_FOR_PRIV(stream_info); - SM_NULL_ARG_CHECK_FOR_PRIV(device); if ((ret = __check_manual_route_type(stream_info))) return ret; @@ -2038,7 +2037,6 @@ int _remove_device_id_for_stream_routing(sound_stream_info_s *stream_info, int d MMSoundDevice_t device = NULL; SM_INSTANCE_CHECK_FOR_PRIV(stream_info); - SM_NULL_ARG_CHECK_FOR_PRIV(device); if ((ret = __check_manual_route_type(stream_info))) return ret; diff --git a/test/sound_manager_test.c b/test/sound_manager_test.c index ce2f39e..0321611 100644 --- a/test/sound_manager_test.c +++ b/test/sound_manager_test.c @@ -230,9 +230,9 @@ void _interpret_main_menu(char *cmd) else if (strncmp(cmd, "rds", 3) == 0) g_menu_state = CURRENT_STATUS_REMOVE_DEVICE_FOR_STREAM_ROUTING; else if (strncmp(cmd, "adi", 3) == 0) - g_menu_state = CURRENT_STATUS_ADD_DEVICE_FOR_STREAM_ROUTING; + g_menu_state = CURRENT_STATUS_ADD_DEVICE_ID_FOR_STREAM_ROUTING; else if (strncmp(cmd, "rdi", 3) == 0) - g_menu_state = CURRENT_STATUS_REMOVE_DEVICE_FOR_STREAM_ROUTING; + g_menu_state = CURRENT_STATUS_REMOVE_DEVICE_ID_FOR_STREAM_ROUTING; else if (strncmp(cmd, "aps", 3) == 0) g_menu_state = CURRENT_STATUS_APPLY_STREAM_ROUTING; else if (strncmp(cmd, "sso", 3) == 0)