From: Liu Jian <liujian56@huawei.com>
Date: Tue, 22 Jan 2019 22:45:37 +0000 (+0800)
Subject: driver: uio: fix possible memory leak in __uio_register_device
X-Git-Tag: v5.4-rc1~1512^2~98
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1a392b3de7c5747506b38fc14b2e79977d3c7770;p=platform%2Fkernel%2Flinux-rpi.git

driver: uio: fix possible memory leak in __uio_register_device

'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index effe728..f23ef23 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner,
 	atomic_set(&idev->event, 0);
 
 	ret = uio_get_minor(idev);
-	if (ret)
+	if (ret) {
+		kfree(idev);
 		return ret;
+	}
 
 	idev->dev.devt = MKDEV(uio_major, idev->minor);
 	idev->dev.class = &uio_class;