From: Colin Ian King Date: Fri, 27 Jan 2017 15:06:46 +0000 (+0000) Subject: net: ethernet: aquantia: return -ETIME in macro AQ_HW_WAIT_FOR X-Git-Tag: v4.11-rc1~124^2~295 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1a28242bac44b9eb24fb2e84131256cb3c63372c;p=platform%2Fkernel%2Flinux-exynos.git net: ethernet: aquantia: return -ETIME in macro AQ_HW_WAIT_FOR The macro is returning ETIME which means various checks to see if the returned err is less than zero never work. I believe a -ETIME should be returned instead. Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h index 78fcc0c..03b72dd 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h +++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h @@ -31,7 +31,7 @@ do { \ udelay(_US_); \ } \ if (!AQ_HW_WAIT_FOR_i) {\ - err = ETIME; \ + err = -ETIME; \ } \ } while (0)