From: Thorsten Winkler <twinkler@linux.ibm.com>
Date: Wed, 21 Jun 2023 13:49:19 +0000 (+0200)
Subject: s390/lcs: Convert sprintf to scnprintf
X-Git-Tag: v6.6.7~2536^2~26^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1a079f3e95295c3534c89f008e5e961a386e25e9;p=platform%2Fkernel%2Flinux-starfive.git

s390/lcs: Convert sprintf to scnprintf

This LWN article explains the why scnprintf is preferred over snprintf
in general
https://lwn.net/Articles/69419/
Ie. snprintf() returns what *would* be the resulting length, while
scnprintf() returns the actual length.

Reported-by: Jules Irenge <jbi.octave@gmail.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Thorsten Winkler <twinkler@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/drivers/s390/net/lcs.h b/drivers/s390/net/lcs.h
index bd52caa..a2699b7 100644
--- a/drivers/s390/net/lcs.h
+++ b/drivers/s390/net/lcs.h
@@ -21,7 +21,7 @@ do { \
 #define LCS_DBF_TEXT_(level,name,text...) \
 	do { \
 		if (debug_level_enabled(lcs_dbf_##name, level)) { \
-			sprintf(debug_buffer, text); \
+			scnprintf(debug_buffer, sizeof(debug_buffer), text); \
 			debug_text_event(lcs_dbf_##name, level, debug_buffer); \
 		} \
 	} while (0)