From: Johannes Thumshirn Date: Wed, 20 Jan 2016 15:08:40 +0000 (+0100) Subject: lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl X-Git-Tag: v4.14-rc1~3462^2~154 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=19db2307365231e798bb99324ed553bcada57913;p=platform%2Fkernel%2Flinux-rpi.git lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl This removes a redundant code block that will either be executed if the ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code is just duplicated in both cases, hence we unify it again. This probably is a left over from some sort of refactoring. Signed-off-by: Johannes Thumshirn Reviewed-by: Matthew R. Ochs Reviewed-by: Tomas Henzl Reviewed-by: Sebastian Herbszt Acked-by: Dick Kennedy Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 152b3c8..3bd0be6 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++ b/drivers/scsi/lpfc/lpfc_scsi.c @@ -4139,23 +4139,6 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn, /* The sdev is not guaranteed to be valid post scsi_done upcall. */ cmd->scsi_done(cmd); - if (phba->cfg_poll & ENABLE_FCP_RING_POLLING) { - spin_lock_irqsave(&phba->hbalock, flags); - lpfc_cmd->pCmd = NULL; - spin_unlock_irqrestore(&phba->hbalock, flags); - - /* - * If there is a thread waiting for command completion - * wake up the thread. - */ - spin_lock_irqsave(shost->host_lock, flags); - if (lpfc_cmd->waitq) - wake_up(lpfc_cmd->waitq); - spin_unlock_irqrestore(shost->host_lock, flags); - lpfc_release_scsi_buf(phba, lpfc_cmd); - return; - } - spin_lock_irqsave(&phba->hbalock, flags); lpfc_cmd->pCmd = NULL; spin_unlock_irqrestore(&phba->hbalock, flags);