From: Sven Peter <sven@svenpeter.dev>
Date: Mon, 14 Nov 2022 17:44:46 +0000 (+0100)
Subject: usb: typec: tipd: Cleanup resources if devm_tps6598_psy_register fails
X-Git-Tag: v6.6.7~3884^2~76
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=19c220e9ab00f50edefb9667e3101e84a5112df2;p=platform%2Fkernel%2Flinux-starfive.git

usb: typec: tipd: Cleanup resources if devm_tps6598_psy_register fails

We can't just return if devm_tps6598_psy_register fails since previous
resources are not devres managed and have yet to be cleaned up.

Fixes: 10eb0b6ac63a ("usb: typec: tps6598x: Export some power supply properties")
Signed-off-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20221114174449.34634-1-sven@svenpeter.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 2a77bab..83a7a82 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -814,7 +814,7 @@ static int tps6598x_probe(struct i2c_client *client)
 
 	ret = devm_tps6598_psy_register(tps);
 	if (ret)
-		return ret;
+		goto err_role_put;
 
 	tps->port = typec_register_port(&client->dev, &typec_cap);
 	if (IS_ERR(tps->port)) {