From: Maninder Singh Date: Thu, 16 Jul 2015 03:55:33 +0000 (+0530) Subject: ath10k: fix wrong initialization of struct channel X-Git-Tag: v4.3-rc1~96^2~124^2~10^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=19be9e9a7ac7e6050eab426283d2a87593cf6e82;p=platform%2Fkernel%2Flinux-exynos.git ath10k: fix wrong initialization of struct channel chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. Channel should be initialized after obtaining chandef. Found by cppcheck: ath/ath10k/mac.c:839]: (error) Possible null pointer dereference: chandef Signed-off-by: Maninder Singh Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index c9a7d5b..49a54a1 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar) static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id) { struct cfg80211_chan_def *chandef = NULL; - struct ieee80211_channel *channel = chandef->chan; + struct ieee80211_channel *channel = NULL; struct wmi_vdev_start_request_arg arg = {}; int ret = 0;