From: Louis Dionne Date: Thu, 30 Sep 2021 17:23:39 +0000 (-0400) Subject: [libc++] Simplify writing testing config files X-Git-Tag: upstream/15.0.7~29414 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=19a3e24803a69090f4163c20a6511213e1c07de6;p=platform%2Fupstream%2Fllvm.git [libc++] Simplify writing testing config files Reduce code duplication by sharing most of the test suite setup across the different from-scratch configs. Differential Revision: https://reviews.llvm.org/D111196 --- diff --git a/libcxx/test/CMakeLists.txt b/libcxx/test/CMakeLists.txt index 58e95b8..4f0333b 100644 --- a/libcxx/test/CMakeLists.txt +++ b/libcxx/test/CMakeLists.txt @@ -130,6 +130,10 @@ endif() if (LIBCXX_INCLUDE_TESTS) include(AddLLVM) # for configure_lit_site_cfg and add_lit_testsuite + configure_file("${CMAKE_CURRENT_SOURCE_DIR}/configs/cmake-bridge.cfg.in" + "${CMAKE_CURRENT_BINARY_DIR}/cmake-bridge.cfg" + @ONLY) + configure_lit_site_cfg( "${LIBCXX_TEST_CONFIG}" ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg diff --git a/libcxx/test/configs/apple-libc++-shared.cfg.in b/libcxx/test/configs/apple-libc++-shared.cfg.in index 8ae5549..cf1490d 100644 --- a/libcxx/test/configs/apple-libc++-shared.cfg.in +++ b/libcxx/test/configs/apple-libc++-shared.cfg.in @@ -1,8 +1,3 @@ -@AUTO_GEN_COMMENT@ - -@SERIALIZED_LIT_PARAMS@ - -# # Testing configuration for Apple's system libc++. # # This configuration differs from a normal LLVM shared library configuration in @@ -11,57 +6,27 @@ # # We also don't use a per-target include directory layout, so we have only one # include directory for the libc++ headers. -# - -LIBCXX_ROOT = "@LIBCXX_SOURCE_DIR@" -INSTALL_ROOT = "@CMAKE_BINARY_DIR@" -COMPILER = "@CMAKE_CXX_COMPILER@" -EXEC_ROOT = "@LIBCXX_BINARY_DIR@" -CMAKE_OSX_SYSROOT = "@CMAKE_OSX_SYSROOT@" -INCLUDE_DIR = "@LIBCXX_INSTALL_INCLUDE_DIR@" -LIBRARY_DIR = "@LIBCXX_INSTALL_LIBRARY_DIR@" -import os -import pipes -import site import sys -site.addsitedir(os.path.join(LIBCXX_ROOT, 'utils')) -import libcxx.test.features -import libcxx.test.format -import libcxx.test.newconfig -import libcxx.test.params -# Configure basic properties of the test suite -config.name = 'libcxx-trunk-shared' -config.test_source_root = os.path.join(LIBCXX_ROOT, 'test') -config.test_format = libcxx.test.format.CxxStandardLibraryTest() -config.recursiveExpansionLimit = 10 -config.test_exec_root = EXEC_ROOT +lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') -# Configure basic substitutions -runPy = os.path.join(LIBCXX_ROOT, 'utils', 'run.py') -config.substitutions.append(('%{cxx}', COMPILER)) config.substitutions.append(('%{flags}', - '-isysroot {}'.format(CMAKE_OSX_SYSROOT) if CMAKE_OSX_SYSROOT else '' + '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else '' )) config.substitutions.append(('%{compile_flags}', - '-nostdinc++ -isystem {} -I {}'.format( - os.path.join(INSTALL_ROOT, INCLUDE_DIR), - os.path.join(LIBCXX_ROOT, 'test', 'support')) + '-nostdinc++ -isystem %{install}/include/c++/v1 -I %{libcxx}/test/support' )) config.substitutions.append(('%{link_flags}', - '-nostdlib++ -L {} -lc++'.format( - os.path.join(INSTALL_ROOT, LIBRARY_DIR)) + '-nostdlib++ -L %{install}/lib -lc++' )) config.substitutions.append(('%{exec}', - '{} {} --execdir %T --env DYLD_LIBRARY_PATH={} -- '.format( - pipes.quote(sys.executable), - pipes.quote(runPy), - pipes.quote(os.path.join(INSTALL_ROOT, LIBRARY_DIR))) + '{} %{{libcxx}}/utils/run.py --execdir %T --env DYLD_LIBRARY_PATH=%{{install}}/lib -- '.format(sys.executable) )) -config.substitutions.append(('%{install}', INSTALL_ROOT)) -# Add parameters and features to the config +import os, site +site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils')) +import libcxx.test.params, libcxx.test.newconfig, libcxx.test.newconfig libcxx.test.newconfig.configure( libcxx.test.params.DEFAULT_PARAMETERS, libcxx.test.features.DEFAULT_FEATURES, diff --git a/libcxx/test/configs/cmake-bridge.cfg.in b/libcxx/test/configs/cmake-bridge.cfg.in new file mode 100644 index 0000000..e60845e --- /dev/null +++ b/libcxx/test/configs/cmake-bridge.cfg.in @@ -0,0 +1,31 @@ +@AUTO_GEN_COMMENT@ + +@SERIALIZED_LIT_PARAMS@ + +# +# This file performs the bridge between the CMake configuration and the Lit +# configuration files by setting up the LitConfig object and various Lit +# substitutions from CMake variables. +# +# Individual configuration files can take advantage of this bridge by +# loading the file and then setting up the remaining Lit substitutions. +# + +import os, site +site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils')) +import libcxx.test.format + +# Basic configuration of the test suite +config.name = os.path.basename('@LIBCXX_TEST_CONFIG@') +config.test_source_root = os.path.join('@LIBCXX_SOURCE_DIR@', 'test') +config.test_format = libcxx.test.format.CxxStandardLibraryTest() +config.recursiveExpansionLimit = 10 +config.test_exec_root = '@CMAKE_BINARY_DIR@' + +# Add substitutions for bootstrapping the test suite configuration +config.substitutions.append(('%{cxx}', '@CMAKE_CXX_COMPILER@')) +config.substitutions.append(('%{libcxx}', '@LIBCXX_SOURCE_DIR@')) +config.substitutions.append(('%{install}', '@CMAKE_BINARY_DIR@')) +config.substitutions.append(('%{include}', '%{install}/@LIBCXX_INSTALL_INCLUDE_DIR@')) +config.substitutions.append(('%{target-include}', '%{install}/@LIBCXX_INSTALL_INCLUDE_TARGET_DIR@')) +config.substitutions.append(('%{lib}', '%{install}/@LIBCXX_INSTALL_LIBRARY_DIR@')) diff --git a/libcxx/test/configs/llvm-libc++-shared.cfg.in b/libcxx/test/configs/llvm-libc++-shared.cfg.in index dd2de28..54220ca 100644 --- a/libcxx/test/configs/llvm-libc++-shared.cfg.in +++ b/libcxx/test/configs/llvm-libc++-shared.cfg.in @@ -1,61 +1,26 @@ -@AUTO_GEN_COMMENT@ - -@SERIALIZED_LIT_PARAMS@ - -# # This testing configuration handles running the test suite against LLVM's libc++ # using a shared library. -# - -LIBCXX_ROOT = "@LIBCXX_SOURCE_DIR@" -INSTALL_ROOT = "@CMAKE_BINARY_DIR@" -COMPILER = "@CMAKE_CXX_COMPILER@" -EXEC_ROOT = "@LIBCXX_BINARY_DIR@" -CMAKE_OSX_SYSROOT = "@CMAKE_OSX_SYSROOT@" -INCLUDE_DIR = "@LIBCXX_INSTALL_INCLUDE_DIR@" -INCLUDE_TARGET_DIR = "@LIBCXX_INSTALL_INCLUDE_TARGET_DIR@" -LIBRARY_DIR = "@LIBCXX_INSTALL_LIBRARY_DIR@" -import os -import pipes -import site import sys -site.addsitedir(os.path.join(LIBCXX_ROOT, 'utils')) -import libcxx.test.features -import libcxx.test.format -import libcxx.test.newconfig -import libcxx.test.params -# Configure basic properties of the test suite -config.name = 'llvm-libc++-shared' -config.test_source_root = os.path.join(LIBCXX_ROOT, 'test') -config.test_format = libcxx.test.format.CxxStandardLibraryTest() -config.recursiveExpansionLimit = 10 -config.test_exec_root = EXEC_ROOT +lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') -# Configure basic substitutions -runPy = os.path.join(LIBCXX_ROOT, 'utils', 'run.py') -config.substitutions.append(('%{cxx}', COMPILER)) config.substitutions.append(('%{flags}', - '-isysroot {}'.format(CMAKE_OSX_SYSROOT) if CMAKE_OSX_SYSROOT else '' + '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else '' )) config.substitutions.append(('%{compile_flags}', - '-nostdinc++ -isystem {} -isystem {} -I {}'.format( - os.path.join(INSTALL_ROOT, INCLUDE_DIR), - os.path.join(INSTALL_ROOT, INCLUDE_TARGET_DIR), - os.path.join(LIBCXX_ROOT, 'test', 'support')) + '-nostdinc++ -isystem %{include} -isystem %{target-include} -I %{libcxx}/test/support' )) config.substitutions.append(('%{link_flags}', - '-nostdlib++ -L {0} -lc++ -Wl,-rpath,{0} -pthread'.format( - os.path.join(INSTALL_ROOT, LIBRARY_DIR)) + '-nostdlib++ -L %{lib} -Wl,-rpath,%{lib} -lc++ -pthread' )) config.substitutions.append(('%{exec}', - '{} {} --execdir %T -- '.format( - pipes.quote(sys.executable), - pipes.quote(runPy)) + '{} %{{libcxx}}/utils/run.py --execdir %T -- '.format(sys.executable) )) -# Add parameters and features to the config +import os, site +site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils')) +import libcxx.test.params, libcxx.test.newconfig, libcxx.test.newconfig libcxx.test.newconfig.configure( libcxx.test.params.DEFAULT_PARAMETERS, libcxx.test.features.DEFAULT_FEATURES, diff --git a/libcxx/test/configs/llvm-libc++-static.cfg.in b/libcxx/test/configs/llvm-libc++-static.cfg.in index 925e2f1..00878da 100644 --- a/libcxx/test/configs/llvm-libc++-static.cfg.in +++ b/libcxx/test/configs/llvm-libc++-static.cfg.in @@ -1,61 +1,26 @@ -@AUTO_GEN_COMMENT@ - -@SERIALIZED_LIT_PARAMS@ - -# # This testing configuration handles running the test suite against LLVM's libc++ # using a static library. -# - -LIBCXX_ROOT = "@LIBCXX_SOURCE_DIR@" -INSTALL_ROOT = "@CMAKE_BINARY_DIR@" -COMPILER = "@CMAKE_CXX_COMPILER@" -EXEC_ROOT = "@LIBCXX_BINARY_DIR@" -CMAKE_OSX_SYSROOT = "@CMAKE_OSX_SYSROOT@" -INCLUDE_DIR = "@LIBCXX_INSTALL_INCLUDE_DIR@" -INCLUDE_TARGET_DIR = "@LIBCXX_INSTALL_INCLUDE_TARGET_DIR@" -LIBRARY_DIR = "@LIBCXX_INSTALL_LIBRARY_DIR@" -import os -import pipes -import site import sys -site.addsitedir(os.path.join(LIBCXX_ROOT, 'utils')) -import libcxx.test.features -import libcxx.test.format -import libcxx.test.newconfig -import libcxx.test.params -# Configure basic properties of the test suite -config.name = 'llvm-libc++-static' -config.test_source_root = os.path.join(LIBCXX_ROOT, 'test') -config.test_format = libcxx.test.format.CxxStandardLibraryTest() -config.recursiveExpansionLimit = 10 -config.test_exec_root = EXEC_ROOT +lit_config.load_config(config, '@CMAKE_CURRENT_BINARY_DIR@/cmake-bridge.cfg') -# Configure basic substitutions -runPy = os.path.join(LIBCXX_ROOT, 'utils', 'run.py') -config.substitutions.append(('%{cxx}', COMPILER)) config.substitutions.append(('%{flags}', - '-isysroot {}'.format(CMAKE_OSX_SYSROOT) if CMAKE_OSX_SYSROOT else '' + '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else '' )) config.substitutions.append(('%{compile_flags}', - '-nostdinc++ -isystem {} -isystem {} -I {}'.format( - os.path.join(INSTALL_ROOT, INCLUDE_DIR), - os.path.join(INSTALL_ROOT, INCLUDE_TARGET_DIR), - os.path.join(LIBCXX_ROOT, 'test', 'support')) + '-nostdinc++ -isystem %{include} -isystem %{target-include} -I %{libcxx}/test/support' )) config.substitutions.append(('%{link_flags}', - '-nostdlib++ -L {} -lc++ -lc++abi -pthread'.format( - os.path.join(INSTALL_ROOT, LIBRARY_DIR)) + '-nostdlib++ -L %{lib} -lc++ -lc++abi -pthread' )) config.substitutions.append(('%{exec}', - '{} {} --execdir %T -- '.format( - pipes.quote(sys.executable), - pipes.quote(runPy)) + '{} %{{libcxx}}/utils/run.py --execdir %T -- '.format(sys.executable) )) -# Add parameters and features to the config +import os, site +site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils')) +import libcxx.test.params, libcxx.test.newconfig, libcxx.test.newconfig libcxx.test.newconfig.configure( libcxx.test.params.DEFAULT_PARAMETERS, libcxx.test.features.DEFAULT_FEATURES, diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py index 73dd544..34e3c48 100644 --- a/libcxx/utils/libcxx/test/params.py +++ b/libcxx/utils/libcxx/test/params.py @@ -60,6 +60,7 @@ DEFAULT_PARAMETERS = [ actions=lambda triple: filter(None, [ AddFeature('target={}'.format(triple)), AddFlagIfSupported('--target={}'.format(triple)), + AddSubstitution('%{triple}', triple) ])), Parameter(name='std', choices=_allStandards, type=str,