From: Daniel Jasper Date: Tue, 2 Jun 2015 15:14:21 +0000 (+0000) Subject: clang-format: [JS] Fix incorrect line length calculation. X-Git-Tag: llvmorg-3.7.0-rc1~3201 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=199d0c9e764e69895d3d79553696de514be31ad2;p=platform%2Fupstream%2Fllvm.git clang-format: [JS] Fix incorrect line length calculation. llvm-svn: 238841 --- diff --git a/clang/lib/Format/ContinuationIndenter.cpp b/clang/lib/Format/ContinuationIndenter.cpp index 39b2793..204bcc9d 100644 --- a/clang/lib/Format/ContinuationIndenter.cpp +++ b/clang/lib/Format/ContinuationIndenter.cpp @@ -159,7 +159,8 @@ bool ContinuationIndenter::mustBreak(const LineState &State) { if (((Previous.is(TT_DictLiteral) && Previous.is(tok::l_brace)) || Previous.is(TT_ArrayInitializerLSquare)) && Style.ColumnLimit > 0 && - getLengthToMatchingParen(Previous) + State.Column > getColumnLimit(State)) + getLengthToMatchingParen(Previous) + State.Column - 1 > + getColumnLimit(State)) return true; if (Current.is(TT_CtorInitializerColon) && ((Style.AllowShortFunctionsOnASingleLine != FormatStyle::SFS_All) || diff --git a/clang/unittests/Format/FormatTestJS.cpp b/clang/unittests/Format/FormatTestJS.cpp index 25113ab..a18d35b 100644 --- a/clang/unittests/Format/FormatTestJS.cpp +++ b/clang/unittests/Format/FormatTestJS.cpp @@ -259,7 +259,8 @@ TEST_F(FormatTestJS, ArrayLiterals) { "]);"); verifyFormat("var someVariable = SomeFuntion([\n" " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n" - "]);"); + "]);", + getGoogleJSStyleWithColumns(51)); verifyFormat("var someVariable = SomeFuntion(aaaa, [\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"