From: kernel test robot Date: Wed, 19 Jan 2022 05:24:47 +0000 (+0100) Subject: media: ov5693: fix returnvar.cocci warnings X-Git-Tag: v6.1-rc5~1763^2~175 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1949c01efefb09bc017b7a6659aa120ae8c9d066;p=platform%2Fkernel%2Flinux-starfive.git media: ov5693: fix returnvar.cocci warnings drivers/media/i2c/ov5693.c:953:5-8: Unneeded variable: "ret". Return "0" on line 985 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci [Sakari Ailus: Improved subject] CC: Daniel Scally Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index 4a5aa6e0..117ff54 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd, unsigned int width, height; unsigned int hblank; int exposure_max; - int ret = 0; crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which); @@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd, format->format = *fmt; if (format->which == V4L2_SUBDEV_FORMAT_TRY) - return ret; + return 0; mutex_lock(&ov5693->lock); @@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd, exposure_max)); mutex_unlock(&ov5693->lock); - return ret; + return 0; } static int ov5693_get_selection(struct v4l2_subdev *sd,