From: Markus Elfring Date: Sun, 28 Jun 2015 09:15:28 +0000 (+0200) Subject: ALSA: hda: Delete an unnecessary check before the function call "snd_info_free_entry" X-Git-Tag: v4.14-rc1~4700^2~69 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1947a114bff140b35bbad1c84a5af216f8416281;p=platform%2Fkernel%2Flinux-rpi.git ALSA: hda: Delete an unnecessary check before the function call "snd_info_free_entry" The snd_info_free_entry() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index f852734..2f24338 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -591,7 +591,7 @@ static int eld_proc_new(struct hdmi_spec_per_pin *per_pin, int index) static void eld_proc_free(struct hdmi_spec_per_pin *per_pin) { - if (!per_pin->codec->bus->shutdown && per_pin->proc_entry) { + if (!per_pin->codec->bus->shutdown) { snd_info_free_entry(per_pin->proc_entry); per_pin->proc_entry = NULL; }