From: Wim Taymans <wim.taymans@collabora.co.uk>
Date: Wed, 11 Mar 2009 13:08:10 +0000 (+0100)
Subject: rtsp: free the right string.
X-Git-Tag: 1.19.3~511^2~9890
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18f612ffa937f0afed5068fe255ccd34b9b8269a;p=platform%2Fupstream%2Fgstreamer.git

rtsp: free the right string.

Free the key value before we remove the header item from the array. The item we
retrieved from the array is only valid until we remove it from the array.
---

diff --git a/gst-libs/gst/rtsp/gstrtspmessage.c b/gst-libs/gst/rtsp/gstrtspmessage.c
index 5df3fbf..9fde2e2 100644
--- a/gst-libs/gst/rtsp/gstrtspmessage.c
+++ b/gst-libs/gst/rtsp/gstrtspmessage.c
@@ -563,8 +563,8 @@ gst_rtsp_message_remove_header (GstRTSPMessage * msg, GstRTSPHeaderField field,
     RTSPKeyValue *key_value = &g_array_index (msg->hdr_fields, RTSPKeyValue, i);
 
     if (key_value->field == field && (indx == -1 || cnt++ == indx)) {
-      g_array_remove_index (msg->hdr_fields, i);
       g_free (key_value->value);
+      g_array_remove_index (msg->hdr_fields, i);
       res = GST_RTSP_OK;
       if (indx != -1)
         break;