From: Enric Balletbo i Serra Date: Mon, 10 Dec 2018 18:00:02 +0000 (+0100) Subject: mfd: cros_ec_dev: Add missing mfd_remove_devices() call in remove X-Git-Tag: v5.4-rc1~1792^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18e294ddafaeb80a1e2e10c9bd750a6cb8388d5b;p=platform%2Fkernel%2Flinux-rpi.git mfd: cros_ec_dev: Add missing mfd_remove_devices() call in remove The driver adds different MFD child devices via mfd_add_devices() and hence it is required to call mfd_remove_devices() to remove MFD child devices. Fixes: 5e0115581bbc ("cros_ec: Move cros_ec_dev module to drivers/mfd") Signed-off-by: Enric Balletbo i Serra Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 8f9d696..ff788d3 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -493,6 +493,7 @@ static int ec_device_remove(struct platform_device *pdev) cros_ec_debugfs_remove(ec); + mfd_remove_devices(ec->dev); cdev_del(&ec->cdev); device_unregister(&ec->class_dev); return 0;